Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scrollbars in Firefox #1815

Closed
tcitworld opened this issue Jan 15, 2020 · 8 comments · Fixed by #2498
Closed

Remove scrollbars in Firefox #1815

tcitworld opened this issue Jan 15, 2020 · 8 comments · Fixed by #2498
Labels
1. to develop Accepted and waiting to be taken care of bug priority
Milestone

Comments

@tcitworld
Copy link
Member

tcitworld commented Jan 15, 2020

Firefox adds horizontal and vertical scrollbars due to

.fc * {
  box-sizing: content-box !important;
}

#1809 (comment)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tcitworld tcitworld added 1. to develop Accepted and waiting to be taken care of bug labels Jan 15, 2020
@georgehrke
Copy link
Member

georgehrke commented Jan 15, 2020

tl;dr:

  • full-calendar is using a mix of border-box and content-box:
    3FD944A5-F77A-44BE-91A4-0CC45CABC7B6
  • the server is setting it to border-box:
#content[class*='app-'] * {
    box-sizing: border-box;
}

That breaks plenty of things including positioning of events

  • We override the server css for fullcalendar and set it to content box:
.fc * {
    box-sizing: content-box !important;
}

Which is causing the scrollbar issue in Firefox.

@georgehrke georgehrke added this to the 2.0.1 milestone Jan 15, 2020
@georgehrke
Copy link
Member

Possible solution: https://caniuse.com/#feat=css-all

@georgehrke
Copy link
Member

As a nasty side-effect, this is causing issues when trying to scroll hours in the time-picker: #2003

@georgehrke
Copy link
Member

We can't use all.
The value we would have to use is revert, but that's not supported by Edge / Chrome: https://caniuse.com/#search=all%3A%20revert

@tcitworld
Copy link
Member Author

tcitworld commented Feb 27, 2020

I can't manage to get the scrollbars anymore with Firefox 73.0.1 on 2.0.1 or master, did I miss something?

@georgehrke
Copy link
Member

We just hid them in #1809, but that's not a proper fix :)

1 similar comment
@georgehrke

This comment has been minimized.

@tcitworld
Copy link
Member Author

Sorry, I'm forgetting stuff. /o\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug priority
Projects
None yet
2 participants