Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a shared calendar via link fails if the calendar contains non- compliant VComponents #4430

Open
miaulalala opened this issue Aug 18, 2022 · 5 comments
Open

Adding a shared calendar via link fails if the calendar contains non- compliant VComponents #4430

miaulalala opened this issue Aug 18, 2022 · 5 comments
Labels
0. to triage Pending approval or rejection bug

Comments

@miaulalala
Copy link
Contributor

Steps to reproduce

Add a google calendar via share link.

{
   "reqId":"WPDmb1ev23ZvuZRZGshW",
   "level":2,
   "time":"2022-08-18T12:45:55+00:00",
   "remoteAddr":"127.0.0.1",
   "user":"admin",
   "app":"dav",
   "method":"MKCOL",
   "url":"/remote.php/dav/calendars/admin/calendargooglecom-1",
   "message":"Subscription 2 could not be parsed",
   "userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36",
   "version":"25.0.0.5",
   "exception":{
      "Exception":"Sabre\\VObject\\ParseException",
      "Message":"This parser only supports VCARD and VCALENDAR files",
      "Code":0,
      "Trace":[
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Parser/MimeDir.php",
            "line":90,
            "function":"parseDocument",
            "class":"Sabre\\VObject\\Parser\\MimeDir",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Reader.php",
            "line":47,
            "function":"parse",
            "class":"Sabre\\VObject\\Parser\\MimeDir",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php",
            "line":250,
            "function":"read",
            "class":"Sabre\\VObject\\Reader",
            "type":"::"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php",
            "line":89,
            "function":"queryWebcalFeed",
            "class":"OCA\\DAV\\CalDAV\\WebcalCaching\\RefreshWebcalService",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/Listener/SubscriptionListener.php",
            "line":63,
            "function":"refreshSubscription",
            "class":"OCA\\DAV\\CalDAV\\WebcalCaching\\RefreshWebcalService",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/lib/private/EventDispatcher/ServiceEventListener.php",
            "line":87,
            "function":"handle",
            "class":"OCA\\DAV\\Listener\\SubscriptionListener",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
            "line":251,
            "function":"__invoke",
            "class":"OC\\EventDispatcher\\ServiceEventListener",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
            "line":73,
            "function":"callListeners",
            "class":"Symfony\\Component\\EventDispatcher\\EventDispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php",
            "line":88,
            "function":"dispatch",
            "class":"Symfony\\Component\\EventDispatcher\\EventDispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php",
            "line":100,
            "function":"dispatch",
            "class":"OC\\EventDispatcher\\EventDispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CalDAV/CalDavBackend.php",
            "line":2453,
            "function":"dispatchTyped",
            "class":"OC\\EventDispatcher\\EventDispatcher",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/CalDAV/CalendarHome.php",
            "line":249,
            "function":"createSubscription",
            "class":"OCA\\DAV\\CalDAV\\CalDavBackend",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/CalDAV/CalendarHome.php",
            "line":93,
            "function":"createExtendedCollection",
            "class":"Sabre\\CalDAV\\CalendarHome",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
            "line":1199,
            "function":"createExtendedCollection",
            "class":"OCA\\DAV\\CalDAV\\CalendarHome",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
            "line":560,
            "function":"createCollection",
            "class":"Sabre\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
            "line":89,
            "function":"httpMkcol",
            "class":"Sabre\\DAV\\CorePlugin",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
            "line":472,
            "function":"emit",
            "class":"Sabre\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
            "line":253,
            "function":"invokeMethod",
            "class":"Sabre\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
            "line":321,
            "function":"start",
            "class":"Sabre\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/lib/Server.php",
            "line":357,
            "function":"exec",
            "class":"Sabre\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/apps/dav/appinfo/v2/remote.php",
            "line":35,
            "function":"exec",
            "class":"OCA\\DAV\\Server",
            "type":"->"
         },
         {
            "file":"/var/www/nextcloud/remote.php",
            "line":167,
            "args":[
               "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"
            ],
            "function":"require_once"
         }
      ],
      "File":"/var/www/nextcloud/3rdparty/sabre/vobject/lib/Parser/MimeDir.php",
      "Line":163,
      "message":"Subscription 2 could not be parsed",
      "exception":{
         
      },
      "CustomMessage":"Subscription 2 could not be parsed"
   }
}

Expected behavior

The parser skips VComponents gracefully and still displays allowed VComponents VCARD and VCALENDAR.

OR

The calendar entry in the left sidebar in calendar shows an error icon that let's the user know there is an issue with this calendar.

Actual behaviour

The parser fails and doesn't show any events at all.

Calendar app version

No response

CalDAV-clients used

Web

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

Apache

Database engine version

MySQL

PHP engine version

PHP 8.0

Nextcloud version

No response

Updated from an older installed version or fresh install

No response

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response
@miaulalala miaulalala added bug 0. to triage Pending approval or rejection labels Aug 18, 2022
@tcitworld
Copy link
Member

Not directly related, but can you share the non-compliant vcomponent in question?

@miaulalala
Copy link
Contributor Author

Not directly related, but can you share the non-compliant vcomponent in question?

no i can't as I couldn't figure out which one it was 😿

Downloaded the entire calendar from Google but I didn't see anything obvious.

Components I had were (as an approximate structure)

VCALENDAR
    VTIMEZONE
       /DAYLIGHT
       /STANDARD
    VTIMEZONE
    VEVENT
       /VALARM
    VEVENT
VCALENDAR

@tcitworld
Copy link
Member

It's likely an issue with a previous end of line rather than a new component start.

I'd say adding OPTION_IGNORE_INVALID_LINES to the parser (we already have OPTION_FORGIVING) would probably do it.

@tcitworld
Copy link
Member

If you have the time, you can play with the debugger and set a breakpoint just before the exception to get the offending line.

@miaulalala
Copy link
Contributor Author

Not yet, but I will hopefully look into it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage Pending approval or rejection bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcitworld @miaulalala