Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see in list if calendar is shared (visible in modal only) #4869

Closed
raimund-schluessler opened this issue Jan 2, 2023 · 4 comments · Fixed by #5098
Closed

Cannot see in list if calendar is shared (visible in modal only) #4869

raimund-schluessler opened this issue Jan 2, 2023 · 4 comments · Fixed by #5098
Assignees
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. feature: accessibility

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Jan 2, 2023

Steps to reproduce

  1. Share a calendar
  2. Look at shared calendar in the calendar list on the left

Expected behavior

There should be an indicator that the calendar is shared.

Actual behaviour

There is no indicator that the calendar is shared and you have to open the calendar settings modal to figure out that the calendar is shared.
Similar to when a calendar is shared with you (where the avatar of the owner is show), a sharing icon should be visible that indicates that the calendar is shared with someone. Clicking the icon should open the calendar settings / sharing modal. It was like this before Calendar 4.2.0.

See here, the "Default calendar" is shared but you have to open the modal to see this, there is no icon anymore:
shared_calendar

Calendar app version

4.2.0

Related to #4515

@raimund-schluessler raimund-schluessler added bug 0. to triage Pending approval or rejection design Related to design, interface, interaction design, UX, etc. feature: accessibility labels Jan 2, 2023
@miaulalala
Copy link
Contributor

cc @nextcloud/designers

@nimishavijay
Copy link
Member

Good point! I remember in a previous discussion with @jancborchardt and possibly @ChristophWurst and @st3iny we decided that calendars shared by other people will show their avatars (without status indicators) and calendars shared by you with other people will show a share icon in place of that, but I can't find any notes regarding this. This seems like a good approach to me.

@miaulalala miaulalala added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection labels Jan 3, 2023
@privatemaker
Copy link
Contributor

@nimishavijay @jancborchardt what do you think of the solution I propose in #5083 which I feel addresses OP's issue here?

@stefan-niedermann
Copy link
Member

cc @nextcloud/designers

@st3iny st3iny self-assigned this Mar 27, 2023
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 27, 2023
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. feature: accessibility
Projects
Development

Successfully merging a pull request may close this issue.

6 participants