Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all holiday calendars from Thunderbird? #6011

Open
nclm opened this issue May 15, 2024 · 4 comments
Open

Add all holiday calendars from Thunderbird? #6011

nclm opened this issue May 15, 2024 · 4 comments
Labels
2. developing Work in progress enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@nclm
Copy link

nclm commented May 15, 2024

Is your feature request related to a problem? Please describe.

I like the fact that we can add holiday calendars straight from Nextcloud, provided by Thunderbird.

Those are the choices in Nextcloud right now (about 56):
https://github.com/nextcloud/server/assets/923008/2a6713da-1ac4-40f5-8054-d1808fcbeecd

However Thunderbird.net offers more calendars that that (about 86):
https://github.com/nextcloud/server/assets/923008/64d172ec-228c-457e-ba67-9bd93e16a28d
as can been seen on https://www.thunderbird.net/en-US/calendar/holidays/

Describe the solution you'd like
Include all calendars offered by Thunderbird in Nextcloud.
Additionally, if there could be a way to automatically update the list in Nextcloud if Thunderbird adds or change their calendar, that would be useful to avoid differences like that in the future.

@nclm nclm added the enhancement New feature request label May 15, 2024
@joshtrichards joshtrichards transferred this issue from nextcloud/server May 15, 2024
@joshtrichards
Copy link
Member

The list is currently manually maintained. It's located here:

https://github.com/nextcloud/calendar/blob/b2d23f855269ab34494701a9df1bcdbd9792a904/src/resources/holiday_calendars.json

It was just updated a few months ago. I'm not sure if some were left out at the time or if new ones have since been added @ Thunderbird.

Feel free to make some additions to it and submit them via a PR. :-)

@joshtrichards joshtrichards added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label May 15, 2024
@nclm
Copy link
Author

nclm commented May 16, 2024

Alright, it seems that https://github.com/nextcloud/calendar/blob/main/src/resources/holiday_calendars.json is simply a copy of https://github.com/thunderbird/thunderbird-website/blob/master/media/caldata/calendars.json, which makes sense.

But Thunderbird is now using https://github.com/thunderbird/thunderbird-website/blob/master/media/caldata/autogen/calendars.json since last year, with (more) calendars auto-updated every quarter from a “calendar provider”. If you are up for using these, replacing holiday_calendars.json with the contents of autogen/calendars.json could do the job (as long as Nextcloud can handle the extra fields (locale, language, updated).

@miaulalala
Copy link
Contributor

Alright, it seems that main/src/resources/holiday_calendars.json is simply a copy of thunderbird/thunderbird-website@master/media/caldata/calendars.json, which makes sense.

But Thunderbird is now using thunderbird/thunderbird-website@master/media/caldata/autogen/calendars.json since last year, with (more) calendars auto-updated every quarter from a “calendar provider”. If you are up for using these, replacing holiday_calendars.json with the contents of autogen/calendars.json could do the job (as long as Nextcloud can handle the extra fields (locale, language, updated).

Feel free to edit the file and push a PR 😄 you can even do it from github by going to https://github.com/nextcloud/calendar/blob/main/src/resources/holiday_calendars.json and clicking "Edit File" in the top right.

@nclm
Copy link
Author

nclm commented May 16, 2024

Great, I made the edit here: #6014

@joshtrichards joshtrichards added the 3. to review Waiting for reviews label May 16, 2024
@miaulalala miaulalala added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
Status: 🏗️ In progress
Development

No branches or pull requests

3 participants