Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed events should send email #6024

Open
Zweihorn opened this issue May 28, 2024 · 4 comments
Open

changed events should send email #6024

Zweihorn opened this issue May 28, 2024 · 4 comments
Assignees
Labels
2. developing Work in progress enhancement New feature request feature: iMip

Comments

@Zweihorn
Copy link

Is your feature request related to a problem? Please describe.

Apparently, changing an event does not send emails to participants about the change and this becomes lost to external clients which accepted the event after the first invitation (e.g., Thunderbird).

Describe the solution you'd like

Changing the date and/or time of an event shall send emails to participants about the change as applicable.

Describe alternatives you've considered

none

Additional context

May be a duplicate but this plethora of issues found with searching "change" made it difficult to find one in due time if this would exist already. 😇

However, keep on the good work and prosper.

🌻

@Zweihorn Zweihorn added the enhancement New feature request label May 28, 2024
@SebastianKrupinski SebastianKrupinski self-assigned this May 29, 2024
@SebastianKrupinski
Copy link
Contributor

@Zweihorn This is a know bug, we are already working on fixing this.

@Zweihorn
Copy link
Author

This is a know bug, we are already working on fixing this.

👍

Just curios which one and which issue number, if I may?

🤔

@SebastianKrupinski
Copy link
Contributor

Confirmed.

Cause

This is being caused by the significant changes test.

https://github.com/nextcloud/server/blob/48e62405021627914c7fc6dd58168e011cb0f574/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php#L109-L114

The sabre/vobject/lib/ITip/Broker class considers only changes to 'DTSTART', 'DTEND', 'DURATION', 'DUE', 'RRULE', 'RDATE', 'EXDATE', 'STATUS' as significant.

Solution

  • Create custom comparison algorithm
  • update sabre dav repo to include other parameters

@Zweihorn
Copy link
Author

Confirmed.

Cause

This is being caused by the significant changes test.

@SebastianKrupinski - THX alot.

Keep on the good work and prosper.

🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request feature: iMip
Projects
Status: 🏗️ In progress
Development

No branches or pull requests

2 participants