Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scary wording on big changes #216

Closed
jospoortvliet opened this issue Mar 14, 2018 · 2 comments
Closed

scary wording on big changes #216

jospoortvliet opened this issue Mar 14, 2018 · 2 comments
Assignees
Labels
2. to review design enhancement enhancement of a already implemented feature/code good first issue papercut small changes that make a difference

Comments

@jospoortvliet
Copy link
Member

jospoortvliet commented Mar 14, 2018

The desktop client has some logic to detect potential sync issues. If, for example, a backup is restored on the server, it will seem that all files are changed - but, of course, the version on the client is probably newer. The client then explains the problem to the user and presents them with two options:

Keep Files or Remove all files

Now we know users don't read and just looking at the options, there seems only one sane option: OF COURSE you want to keep your files! However, if the warning was simply triggered because you uploaded/modified a lot of files on another system, this option will undo all those changes, resulting in data loss.

I suggest we rename these options:

Keep Local Files or Download New Files

@jancborchardt @camilasan

@jospoortvliet jospoortvliet added good first issue papercut small changes that make a difference labels Mar 14, 2018
@jancborchardt
Copy link
Member

Sounds good! (Except only first word should be capitalized ;)

@jancborchardt jancborchardt added design enhancement enhancement of a already implemented feature/code labels Mar 14, 2018
k1l1 added a commit to k1l1/client that referenced this issue Apr 11, 2018
@k1l1
Copy link
Contributor

k1l1 commented Apr 11, 2018

I made some changes, translations are still missing. #246
First time contributing here, so "sorry" if I forgot something.

k1l1 added a commit to k1l1/client that referenced this issue May 19, 2018
juliushaertl added a commit that referenced this issue May 19, 2018
scary wording on big changes #216 (translations missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. to review design enhancement enhancement of a already implemented feature/code good first issue papercut small changes that make a difference
Projects
None yet
Development

No branches or pull requests

5 participants