New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display images with relative sources in text app #21

Closed

4 tasks done

mejo- opened this issue May 28, 2020 · 7 comments

Closed

4 tasks done

Display images with relative sources in text app #21

mejo- opened this issue May 28, 2020 · 7 comments

Labels

Milestone

Routing and relat...

Member

mejo- commented May 28, 2020

In GitLab by @azul on May 28, 2020, 08:24

In order to make use of images in the same folder it would be great if we could use relative links.
Ideally we'd fix this in nextcloud text itself.
Luckily there's already a pull request for it.

Follow up on the pull request and make it work.

As this is a complex topic especially taking into account access rights etc. try to focus on the basic rendering for now.

get back to julius in the pull request - propose to focus on display only first
rebase the pull request
try it out
fix whatever is missing

Member Author

mejo- commented Jun 10, 2020

In GitLab by @azul on Jun 10, 2020, 18:48

marked the checklist item get back to julius in the pull request - propose to focus on display only first as completed

Member Author

mejo- commented Jun 10, 2020

In GitLab by @azul on Jun 10, 2020, 18:48

marked the checklist item rebase the pull request as completed

Member Author

mejo- commented Jun 10, 2020

In GitLab by @azul on Jun 10, 2020, 18:48

marked the checklist item try it out as completed

Member Author

mejo- commented Jun 10, 2020

In GitLab by @azul on Jun 10, 2020, 18:48

marked the checklist item fix whatever is missing as completed

Member Author

mejo- commented Jun 10, 2020

In GitLab by @azul on Jun 10, 2020, 18:48

waiting for a review now.

Member Author

mejo- commented Jun 15, 2020

In GitLab by @azul on Jun 15, 2020, 17:00

merged :)

Member Author

mejo- commented Jun 15, 2020

In GitLab by @azul on Jun 15, 2020, 17:00

closed

mejo- closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment