Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After editing a contact file: ALL selected groups are deleted from the assignment #3563

Closed
Der-K-2000 opened this issue Aug 14, 2023 · 14 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working

Comments

@Der-K-2000
Copy link

Der-K-2000 commented Aug 14, 2023

Steps to reproduce

  1. Open a person's contact
  2. Choose group(s)
  3. Selection of new groups is shown
  4. Save contact item

Expected behavior

New Groups will be saved.

Actual behaviour

Every (!) selected group is deleted from the assignment.

Calendar app version

5.4.0-beta.1

CalDAV-clients used

No response

Browser

Firefox 116.0.2

Client operating system

Windows

Server operating system

No response

Web server

Apache

Database engine version

MySQL

PHP engine version

PHP 8.2

Nextcloud version

27.1.0 beta 1

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

@Der-K-2000 Der-K-2000 added the bug Something isn't working label Aug 14, 2023
@ChristophWurst
Copy link
Member

For clarification, the assignment of the contact's groups is lost, not the groups themselves, right?

@Der-K-2000
Copy link
Author

The assignment is lost.

@Der-K-2000 Der-K-2000 changed the title After editing a contact file: ALL selected groups are deleted! After editing a contact file: ALL selected groups are deleted from the assignment! Aug 14, 2023
@ChristophWurst ChristophWurst changed the title After editing a contact file: ALL selected groups are deleted from the assignment! After editing a contact file: ALL selected groups are deleted from the assignment Aug 14, 2023
@ChristophWurst ChristophWurst transferred this issue from nextcloud/calendar Aug 14, 2023
@alphasixtyfive
Copy link

Confirm observing same behavior after today's update to version 5.4.0

@pkampkam
Copy link

pkampkam commented Sep 15, 2023

Confirm the bug. Clarification: editing a contact removes it from all groups. You do not need to alter selection of groups. Even editing the phone number makes the contact disappear (unassigned) from all the groups. This is serious issue.

EDIT: It is still possible to re-attach to groups from the groups context menu. Of course manually, you need to remember where it should belong to.

@ChristophWurst
Copy link
Member

Is this the same problem as #3516? Then there is a pending PR: #3605

@Der-K-2000
Copy link
Author

Is this the same problem as #3516? Then there is a pending PR: #3605

Nope, completetly different.

@ChristophWurst
Copy link
Member

@alphasixtyfive @Der-K-2000 might want to check out #3605 nevertheless because it fixes the bug for me. I'm not able to create contacts with groups on main but it works on the PR's branch.

@alphasixtyfive
Copy link

I can't really make a patch out of it I presume. I hope PR will be merged soon and an update released as a few people are desperate to get groups working again.

@alphasixtyfive
Copy link

alphasixtyfive commented Sep 20, 2023

After today's update 5.4.1 I'm now able to select the group while creating or editing the contact however if I edit anything other than groups, all groups of that contact get deleted. If you, however, click or focus on Contact groups field not changing anything, groups are saved.

@Der-K-2000 please confirm you are observing same behavior.

@alphasixtyfive
Copy link

@ChristophWurst May we please have this looked at?

@Der-K-2000
Copy link
Author

@Der-K-2000 please confirm you are observing same behavior.

Nothing has changed in v5.4.1 related to the issue I mentioned in the 1st post.

@ChristophWurst
Copy link
Member

This bug needs a page reload to be reproducible. The bug has just been fixed by #3628.

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 22, 2023
@Der-K-2000
Copy link
Author

I can confirm that the bug is finally fixed with v5.4.2

Thanks for the update!

@alphasixtyfive
Copy link

Thank you guys! 5.4.2 fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants