-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "dateCreated" field #131
Comments
This should be added to the RecipeService and the interface. @Teifun2 would you be able to look into this one? |
I like the idea of knowing when a recipe was added -> What if i don't know when i added the recipe to my collection but i know that i did it for my birthday? I cannot find the recipe with this time frame then. In theory we would need the possibility to add "creations" of each recipe, in a way that whenever i cooked the recipe i could say that i have done so. This could also mean that we could allow images for each cooked recipe and maybe even comments? This could even replace the original idea of #8. With As Edit: Just noticed that we dont need to go over None the less i think it would be a good idea to add the |
I started working on this issue in PR #377 When creating own recipes it is obvious, what should happen. However, there are several edge cases when importing recipes from 3rd-party sites. What should happen if an imported recipe
Regarding the validity of formats: The schema.org standard expects Date or DateTime entries (ISO 8601). However, e.g., chefkoch.de seems to ignore this and puts the seconds since Jan, 1st 1970 in Anyway, what is currently implemented and what I would propose is: ignore the fields on import and just set them to the current timestamp. The |
This would combine well with the original author's request of the issue to allow selecting for recipees imported in a certain date range. It might be an option to save the original information from the import in the |
Hi there,
I would love to be able to record dates recipes were made. With a view to future features such as searches based on dates, for the scenario: "Dang! What was that recipe I made for XYZ's birthday in 2015?"
Cheers,
Spike
The text was updated successfully, but these errors were encountered: