Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the services in the backend #299

Open
christianlupus opened this issue Aug 14, 2020 · 0 comments
Open

Refactoring of the services in the backend #299

christianlupus opened this issue Aug 14, 2020 · 0 comments
Labels
Backend Issue or PR related to the backend code enhancement New feature or request maintenance php Pull requests that update Php code

Comments

@christianlupus
Copy link
Collaborator

christianlupus commented Aug 14, 2020

Is your feature request related to a problem? Please describe.
The idea behind a service is a single topic. The current services do not stick to this pattern. In fact, when #298 should be implemented, clearly separated and small classes are needed to make the test useful.

Describe the solution you'd like
A complete refactory of the services and rework of current PHP file structure would be involved. First, logical parts should be identified and these should then be implemented piece by piece.

I started to work on some of these refactorings due to my work in PR #297. However I did not want to blow up that PR too much and also not blow up any currently ongoing development.
A first step might be to define a rough time schedule to synchronize any currently ongoing development.

To make dependency injection work smoothly, it would maybe be a good idea to have "a single service to rule them all".

@christianlupus christianlupus added the enhancement New feature or request label Aug 14, 2020
@christianlupus christianlupus added this to To do in Codebase refactory via automation Sep 29, 2020
@christianlupus christianlupus added Backend Issue or PR related to the backend code php Pull requests that update Php code maintenance labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Issue or PR related to the backend code enhancement New feature or request maintenance php Pull requests that update Php code
Projects
Development

No branches or pull requests

2 participants