Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility for an illustrated guide for disabled people #324

Open
Rumastiker opened this issue Sep 28, 2020 · 7 comments
Open

Possibility for an illustrated guide for disabled people #324

Rumastiker opened this issue Sep 28, 2020 · 7 comments
Labels
dependent enhancement New feature or request

Comments

@Rumastiker
Copy link

Rumastiker commented Sep 28, 2020

Is your feature request related to a problem? Please describe.
I can't add pictures to the steps. I need it for easy language recipes.

Describe the solution you'd like
Inserting pictures in the text boxes

Describe alternatives you've considered
Because only one picture is stored, I see no alternative.

Excuse my simple English sentences, my mother tongue is German. I had to use the google translator ;-)


Depends on #1133

@Rumastiker Rumastiker added the enhancement New feature or request label Sep 28, 2020
@christianlupus
Copy link
Collaborator

Hello. I will answer in German to simplify the communication here. Will try to summarize if possible later.

@Rumastiker Bei den Textfeldern können leider keine Bilder eingebunden werden. Diese enthalten ja nur reinen Text im Moment. Es gab zwar Überlegungen, hier auch Markdown zuzulassen, das ist meines Wissens nach aber nicht realisiert worden.

Ziel bei der App ist es zum Standard konform zu bleiben, der auf Schema.org festgelegt ist. Dort gäne es theoretisch die Möglichkeit, dass Bilder zwischen einzenlen Texten auftauchen. Alternativ könnte man versuchen oben mehrere Bidler in der Kopfzeile zuzulassen.

Würde das helfen?

@Rumastiker
Copy link
Author

Rumastiker commented Sep 28, 2020

Hallo Christian,
n-Zeilen Text der 'Zubereitung' und abwechsend n-Zeilen Bilder wäre genauso gut und würde das Problem beheben. Das wäre schon einmal super, wenn es dem Standard entspricht! Mehr Bilder in der Kopfzeile wäre wahrscheinlich nett, aber nicht dringend nötig. Gerade Menschen mit Handicap (wie mein Sohnemann) benötigen einfache Texte, am Besten mit einem Bild des Arbeitsschrittes.

LG Andreas

Hello Christian,
n-line text of the 'preparation' and alternating n-line pictures would be just as good and would fix the problem. That would be great if it conforms to the standard! More images in the header would probably be nice, but not urgently needed. Especially people with disabilities (like my son) need simple texts, preferably with a picture of the work step.

LG Andreas

@sam-19
Copy link
Contributor

sam-19 commented Sep 28, 2020

I think the idea has been to support Markdown in the instructions section. Markdown can achieve this, but you would still have to host the images in a separate location. In the long run, it would be great if recipes could have file attachments, such as images to embed in the text.

@Rumastiker
Copy link
Author

Hallo Sam.
Now I had to google what Markdown is. Or what Markdown has to do with the problem. If I got it right, Markdown is a simplified 'formatting language'. I understand you want to embed an image in text boxes using the markdown command. Or are all recipes formatted with Markdown? As a user, I don't really care, the main thing is that it works ;-) As a supervisor of end users, I would advise against the manual formatting of characters in the text. Or did you mean that Markdown is used when transferring recipes and that the image must also be transferred when transferring? So, before you argue, clarify the terms.

LG Andreas

@sam-19
Copy link
Contributor

sam-19 commented Sep 29, 2020

@Rumastiker yes, Markdown is a simple text formatting syntax, used by GitHub for example. It was actually @christianlupus who was talking about Markdown and my reply was partly aimed to him. To clarify: using Markdown to display images in the preparation steps would not break recipe schema, because you could provide a written instruction in the image alt tag and when exporting a recipe, just strip the image part leaving the alt text. So displaying images does not require any additional features, Markdown support (once it happens) will make that possible. But, as I mentioned above, the images would still have to be hosted somehow, and that would need some kind of a plan. Maybe Christian can give us his two cents on that.

@christianlupus
Copy link
Collaborator

@sam-19 no, we are in fact not talking of the same thing. The Recipe has a property recipeInstruction that can be of type CreativeWork. This in itself can be an image (as URL or ImageObject). The idea was to have a mixture of plain text (the real instructions) and interactive content (even videos would be possible by this).

I was considering the following regarding the file management: We have already a folder per recipe. We could add more files/images/.... to that folder and allow to access it interactively. There we could add these additional images once we have a clear structure. The same structure I have in mind with #323, #315 and #135.

Nevertheless, adding Markdown support might be another issue #47. There the request is markdown itself (although with intention for images as well).

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants