missing translation of Nutrition Information

[cloud2018]

Description

1. In edit mode in block Nutrition Information "Select option" is not translated and the string is not available in Transifex
2. In view mode in block Nutrition Information the names of nutrions are not translated, but the strings are available in Transifex and are used in the drop down box

Screenshot 1

Screenshot 2

[christianlupus]

In general this should be translatable. In the vue files the translation is prepared. This is most probably an issue with the parser of transifex.

[cloud2018]

@christianlupus yes, when editing the nutrions are translated ("Zuckergehalt" in 1st screenshot) as in your linked file cookbook/src/components/RecipeEdit.vue. Only "Select option" is not translated, perhaps a nextcloud issue, not a cookbook issue.

But in the view-mode the nutrions are not translated. Maybe because the t-functions inside the titles are surrounded by ",

cookbook/src/components/RecipeView.vue

Line 62 in 493d21e

<recipe-nutrition-info-item v-if="('servingSize' in nutrition) && !isNullOrEmpty(nutrition['servingSize'])" :title="t('cookbook', 'Serving Size')" :data="nutrition['servingSize']" />

[christianlupus]

@cloud2018 No I doubt that. The " are there from the Vue.js requirements. The must be there. See e.g. here where it is working.

I just checked and found that the translations seem to be exported from the vue files correctly but are somehow not transferred to transifex. I opened an issue there and now we have to see what's happening next.

[christianlupus]

I just found a workaround for the problem but that needs a complete overhaul of the code base. In fact, after the translation no more arguments should be given. Exampe see the upstream bug report.

[seyfeb]

So you’re saying that writing

<recipe-nutrition-info-item v-if="('sugarContent' in recipe.nutrition) && !isNullOrEmpty(recipe.nutrition['sugarContent'])" :title="t('cookbook', 'Sugar')" :data="recipe.nutrition['sugarContent']" />

as

<recipe-nutrition-info-item v-if="('sugarContent' in recipe.nutrition) && !isNullOrEmpty(recipe.nutrition['sugarContent'])"
  :title="t('cookbook', 'Sugar')" 
  :data="recipe.nutrition['sugarContent']" />

should solve the issue as long as the upstream bug is present? Then, I would update those to have a quick fix.

[christianlupus]

Yes, this is correct. In the example above the regex currently in use by the transifex integration will use Sugar')" :data="recipe.nutrition['sugarContent as the original (English) text which in turn will break other file formats.

One remark: I am just working on issue #532 and #531. During the run of prettier (part of it), the suggested changes from you will be auto-generated. That would speed up that refactoring process much.

[seyfeb]

Alright, I leave you to it then!

[cloud2018]

Is there a workaround for untranslated "Select option" from screenhot 1, too?

[seyfeb]

It wouldn’t’ve worked for “Select option” but should now.

[christianlupus]

With #607 the missing translations should be available by the next nightly run of the nextcloud bot.

I will close here as we have to wait for the next release to get the translations into the app.