Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Not compiling on Musl because it does not have statvfs64 implemented. #6536

Open
5 of 8 tasks
Tumbleweeds opened this issue Mar 11, 2024 · 5 comments
Open
5 of 8 tasks

Comments

@Tumbleweeds
Copy link

⚠️ Before submitting, please verify the following: ⚠️

Bug description

The utility.cpp has a check for defined(Q_OS_UNIX) to use statvfs64 instead of statvfs, but the problem is that it is not available on Linux Musl. As a result, it will not compile on Musl systems.

Steps to reproduce

Compile on a Musl system.

Expected behavior

Successful build.

Which files are affected by this bug

utility.cpp

Operating system

Linux

Which version of the operating system you are running.

Gentoo Musl

Package

Distro package manager

Nextcloud Server version

28.0.2

Nextcloud Desktop Client version

3.12.1

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

No response

Additional info

No response

@Flowdalic
Copy link
Contributor

Downstream Gentoo bug for reference: https://bugs.gentoo.org/924503

@mgallien
Copy link
Collaborator

mgallien commented Mar 12, 2024

@Tumbleweeds
I am pretty sure there would be happy users if a solution would be provided.
As we are generally busy, we will not have time to do it on our own.
I also know that the priority of such a TODO item is very low compared to other TODO items.

Feel free to open a PR for review and we will consider it.

@Flowdalic
Copy link
Contributor

FWIW, while fixing the issue by applying, for example, the patch attached to the Gentoo bug report is only half the battle. The other half is adding a CI job that also builds nextcloud-desktop against Musl, as otherwise we will end up with another Musl incompatibly sooner or later.

@Tumbleweeds
Copy link
Author

I'll be glad to contribute, but I'm not a programmer by trade and I'll have to do some digging before I can provide a good solution.
The Gentoo patch relies on a libc type flag that will not be good for another distribution, so the upstream fix has to be something else.
I'll try to help with the CI job as well.

@Tumbleweeds
Copy link
Author

Downstream Gentoo bug for reference: https://bugs.gentoo.org/924503

I'm the one that filed that, but it needs to rely on the Gentoo ebuild checking for Musl before applying the patch, so it's just a workaround, not a real fix as it will not work for other distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants