Bugfix nextcloudcmd when syncing results in deleting all files

[camilasan]

• Fix for nextcloudcmd hangs with "[ info nextcloud.sync.engine ]: All the files are going to be changed, asking the user" #3144
• Makes warning more concise:

  • warning when deleting all files in the server

    • before:
      
    • after:
      

  • warning when deleting all local files

    • before:
      
    • after:
      

[nimishavijay]

Super nice! Very concise and clear as well!
I would suggest using "Proceed to remove all files" instead :)

[mgallien]

I tested the code as it is without having ever manually modified the setting promptDeleteAllFiles
so default value (false) kicks in and we get no popup in nextcloud graphical full sync client and cmdlightweight client is not getting stuck
if you change the value to true I get the improved popup in the graphical client but the command line one will get stuck again

[camilasan]

I tested the code as it is without having ever manually modified the setting promptDeleteAllFiles
so default value (false) kicks in and we get no popup in nextcloud graphical full sync client and cmdlightweight client is not getting stuck
if you change the value to true I get the improved popup in the graphical client but the command line one will get stuck again

I know and I tried to decouple the 2 things (the sync trigger from cmd and the notification when using the UI) but I couldn't think of a good of doing that.

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6773-19ae6491cde1f676e1422101fe310645fe790bcd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
30 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint