Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opcache.enable_cli=1 still in docker file #769

Closed
godfuture opened this issue Jun 5, 2019 · 3 comments · Fixed by #783
Closed

opcache.enable_cli=1 still in docker file #769

godfuture opened this issue Jun 5, 2019 · 3 comments · Fixed by #783

Comments

@godfuture
Copy link

This ticket nextcloud/server#15471 is part of nc server 16.0.1 (more details here nextcloud/documentation#1439), but it seems not included in docker for tag apache 16 (https://github.com/nextcloud/docker/blob/6357f08f2559cbb7880b82e24bd07305c828a553/16.0/apache/Dockerfile).

There you can find:

{ \
        echo 'opcache.enable=1'; \
        echo 'opcache.enable_cli=1'; \
        echo 'opcache.interned_strings_buffer=8'; \
        echo 'opcache.max_accelerated_files=10000'; \
        echo 'opcache.memory_consumption=128'; \
        echo 'opcache.save_comments=1'; \
        echo 'opcache.revalidate_freq=1'; \
} > /usr/local/etc/php/conf.d/opcache-recommended.ini; \

echo 'opcache.enable_cli=1 is still applied which should not be the case.

@J0WI
Copy link
Contributor

J0WI commented Jun 18, 2019

Would you like to open a PR?

@godfuture
Copy link
Author

Even I share the ambitient of helping the devs, I still think that this is such an easy change, a PR would take longer than the fix itself.

@SnowMB
Copy link
Contributor

SnowMB commented Jun 20, 2019

Even maintainers have to submit their changes through a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants