Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent: Outlook Add-in #48

Closed
jospoortvliet opened this issue Feb 27, 2018 · 10 comments
Closed

Add user agent: Outlook Add-in #48

jospoortvliet opened this issue Feb 27, 2018 · 10 comments
Assignees

Comments

@jospoortvliet
Copy link
Member

The user agents doesn't have our Outlook Add-in in the list. It would be very useful to have it, so you can use auto-tagging and retention to remove attachments after a set time!

We'd need to know from Luc Pasmans what the user agent is, I suppose...

@usselite usselite self-assigned this Feb 27, 2018
@nickvergessen
Copy link
Member

Should also identify the thunderbird one if possible, but i can test that one myself

@usselite
Copy link
Member

The add-in doesn't include a user-agent for now, I can add "Nextcloud Secure Sharing Outlook Add-in" or in case the add-in should have the same user-agent as the thunderbird add-in let me know.

@rullzer
Copy link
Member

rullzer commented Feb 27, 2018

@usselite no it doesn't have to be the same one, actually it is better if they differ ;)

Maybe something like: "Nextcloud Secure Sharing Outlook Add-in/X.Y.Z" where X.Y.Z is the version.

@nickvergessen
Copy link
Member

nickvergessen commented Feb 27, 2018

Best would be to keep it in line with the other agents we use. So I would propose:

  • Outlook: Mozilla/5.0 (<Operating System>) Nextcloud-Outlook v<Version>
    e.g. Mozilla/5.0 (Windows) Nextcloud-Outlook v1.2.3
  • Thunderbird: Mozilla/5.0 (<Operating System>) Nextcloud-Thunderbird v<Version>
    e.g. Mozilla/5.0 (Linux) Nextcloud-Thunderbird v2.2.0

Don't get confused because of the Mozilla/5.0 that's the standard for formating of the user agents.

@usselite
Copy link
Member

usselite commented Mar 2, 2018

I added the proposed format as @nickvergessen mentioned.

Format: Mozilla/5.0 (<Operating System>) Nextcloud-Outlook v<Version>
Sample result: Mozilla/5.0 (Microsoft Windows NT 10.0.16299.0) Nextcloud-Outlook v2.1.0.0

Later today / this weekend I will distribute some new builds.

@nickvergessen
Copy link
Member

Awesome

@jospoortvliet
Copy link
Member Author

This works, we even blogged about it... ;-) Close?

@nickvergessen
Copy link
Member

nickvergessen commented Nov 26, 2018

But only for Outlook, the issue on the thunderbird plugin is still open.
nextcloud/nextcloud-filelink#49

@blizzz
Copy link
Member

blizzz commented Jan 22, 2021

Is the Thunderbird thing dead?

@nickvergessen
Copy link
Member

If this is still an issue in Nextcloud 24 or later, please feel free to create a new issue in https://github.com/nextcloud/server/issues as that is where the "user agent" check code is

@nickvergessen nickvergessen closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants