Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging filter not applied in Nextcloud 28 #860

Open
susnux opened this issue Jan 26, 2024 · 7 comments
Open

Tagging filter not applied in Nextcloud 28 #860

susnux opened this issue Jan 26, 2024 · 7 comments

Comments

@susnux
Copy link

susnux commented Jan 26, 2024

My flow looks like this:
image

In all version before it worked as expected: I have a shared group folder A that is tagged, if someone create a file within that new file is tagged.
Starting with Nextcloud 28 not only files within that folder are tagged, but every new file, even in folders not tagged.

Expected behaviour

Only files in tagged folders are tagged.

Actual behaviour

Every new file is tagged

Server configuration

Operating system: Docker image

Web server: Apache

Database: MariaDB

PHP version: 8.2

Nextcloud version: 28.0.1

Where did you install Nextcloud from: nextcloud docker image

@nickvergessen
Copy link
Member

even in folders not tagged.

Not completely sure what you mean with this, just to clarify.

The rule always applied to any child, independent from the level. So also <this is tagged>/<not tagged 1>/<not tagged 2>/test.txt will make test.txt tagged.

@nickvergessen
Copy link
Member

Only thing that I can imagine is nextcloud/server#40482

This fixes workflows on groupfolders, as it will consider access to files in groupfolders.

🙈

@nickvergessen
Copy link
Member

I just tested this locally and it works fine here. With groupfolder and without.

@susnux
Copy link
Author

susnux commented Jan 26, 2024

Before it worked like this:

- documents
- website
 |- some.md
 |- subfolder 

website was tagged toggledeploy, documents not. Both are groupfolders.

So if I changed anything in website the new file got the tag toggledeploy (which then caused webhooks for website generation).

But now it also adds that toggledeploy tag on new or changed files in documents (or even in subfolders of it).

@nickvergessen
Copy link
Member

Also that I can not reproduce. Can you check on DB level, I assume somehow you managed to get the root folder that hosts all groupfolders tagged?

SELECT *
FROM `oc_systemtag_object_mapping`
WHERE `objecttype` = 'files'
  AND `objectid` IN (
    SELECT fileid  
    FROM `oc_filecache`
    WHERE `path` LIKE '__groupfolders'
  );

@susnux
Copy link
Author

susnux commented Jan 30, 2024

Thank you but nothing there:

MariaDB [nextcloud]> SELECT *
    -> FROM `oc_systemtag_object_mapping`
    -> WHERE `objecttype` = 'files'
    ->   AND `objectid` IN (
    ->     SELECT fileid  
    ->     FROM `oc_filecache`
    ->     WHERE `path` LIKE '__groupfolders'
    ->   );
Empty set (0.062 sec)

If I have following setup:

root
  |--- A
       |--- B
            |--- new.md

And create new.md then new.md and B will be tagged, (A is not tagged and will not be automatically tagged).

@susnux
Copy link
Author

susnux commented Feb 9, 2024

I checked all tags and they are only applied to some files and on groupfolders like:

__groupfolders/6
__groupfolders/8
__groupfolders/10
__groupfolders/versions/6
__groupfolders/versions/8
__groupfolders/versions/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants