Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App not shipped with NC17 and no longer available in store #185

Open
Schmuuu opened this issue Oct 12, 2019 · 9 comments
Open

App not shipped with NC17 and no longer available in store #185

Schmuuu opened this issue Oct 12, 2019 · 9 comments

Comments

@Schmuuu
Copy link

@Schmuuu Schmuuu commented Oct 12, 2019

Hello,

This app is no longer available in the nextcloud app store. The following link leads to an empty page:
https://apps.nextcloud.com/apps/files_texteditor

I think this could be the reason, why this app gets removed during the update of Nextcloud server to version 17.

I originally discovered this issue, when I tried to open markdown files in the plain text editor, but didn't have the option available anymore. Disabling the new app "Text" had the effect, that I could only download .md and .txt files, but they didn't open anymore.
I couldn't find this app in my app section (neither enabled nor disabled) and not on the filesystem.

I tried two things without success:

  • search the app in the app store (to download and enable it again)
  • restore the app from the backup created during NC17 update (no way to update the app then)

Could you please make this app available in the NC store again, please?
I believe many users find this app extremely important; especially because the new "Text" app has a few flaws which make it unusable for a few users.

Thanks a lot.

Edit: Not sure, who is really maintaining the app. Could you have a look here please @juliushaertl , you made one of the last changes :)

@juliushaertl

This comment has been minimized.

Copy link
Member

@juliushaertl juliushaertl commented Oct 23, 2019

Not sure about doing another release since we will mainly focus development on the text app now. cc @rullzer

The app should still work fine for 17 (restored from your backup) if you adjust the max-version in appinfo/info.xml

@vincowl

This comment has been minimized.

Copy link

@vincowl vincowl commented Oct 23, 2019

@juliushaertl so what would be a correct way to have this app available in nextcloud 17 ? Install it by hand through a download, modifying the appinfo/info.xml we have in our server's folders ?

@juliushaertl

This comment has been minimized.

Copy link
Member

@juliushaertl juliushaertl commented Oct 23, 2019

Since the app was bundled with nextcloud max-/min-version were always fixed to the current release.

@Schmuuu

This comment has been minimized.

Copy link
Author

@Schmuuu Schmuuu commented Oct 23, 2019

Not sure about doing another release since we will mainly focus development on the text app now.

The app had min version NC18. Looks like this app will actually be shipped in the future as well. Therefore I thought that might have been a mistake. Also because interestingly the latest app version of files_texteditor released together with (or right before) NC17 is the version 17. But exactly with that release the min version was increased (surprisingly from NC17) to NC18.
This app jumps across one full major release of NC.

The app works fine from the backup, that's true. I haven't tested if the new app works on NC17 as well. However, wouldn't it be a good idea to publish a new release which supports NC17 as well then? Other users will stumble across this issue otherwise, when they update to NC17 and the app will be removed.

Especially with the current state of the app Text, this app is really important for productive usage. Therefore I believe many users would really appreciate when this app here could re-appear in the app store and would not be removed during the NC update.

Thanks a lot.

@rullzer

This comment has been minimized.

Copy link
Member

@rullzer rullzer commented Oct 28, 2019

No it won't be shipped. We could just dump it in the appstore.
I'll try to find some time to do that this week.

@Schmuuu

This comment has been minimized.

Copy link
Author

@Schmuuu Schmuuu commented Oct 28, 2019

Oh nooo 😢
This app is so great. Simple and great. In combination with files_markdown it works absolutely flawless.
Unfortunately the new Text app doesn't work that flawless, but has issues with fomatting changes and data loss.
Please don't remove this app until Text can be used in production without worries.

@BrookeDot

This comment has been minimized.

Copy link

@BrookeDot BrookeDot commented Nov 7, 2019

We could just dump it in the appstore. I'll try to find some time to do that this week.

Thanks @rullzer having it in the appstore will be a big help. There is also an issue open over on the files_markdown app regarding the missing files_texteditor causing breakage in the markdown app (icewind1991/files_markdown#135 ). I think if that app is updated to work with the new Text app then the original app may not be needed. However, for now both Text apps appear to be necessary.

Thanks again for your work!

@wardwouts

This comment has been minimized.

Copy link

@wardwouts wardwouts commented Nov 12, 2019

I'll always have a need for an editor that does not do rendering for me. Or at least lets me turn it off. If that could be a configuration option in the new Text app, it would be fine. Until that time, I prefer the old editor.

@E1k3

This comment has been minimized.

Copy link

@E1k3 E1k3 commented Dec 1, 2019

This really needs to be maintained in the future as the new WYSIWYG "Text" app does not support the preview extension apps that were possible with this editor. I and many others greatly prefer the raw+preview style of editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.