Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firstrun video polishing #224

Closed
rullzer opened this issue Dec 16, 2019 · 5 comments · Fixed by #227
Closed

Firstrun video polishing #224

rullzer opened this issue Dec 16, 2019 · 5 comments · Fixed by #227

Comments

@rullzer
Copy link
Member

rullzer commented Dec 16, 2019

We should

  • Ship the video with the firstrunwizard itself. So that if the default files are modified/deleted it still works
  • Also show the video on pressing about (basically the wizzard is the same in both cases).

CC: @karlitschek @juliushaertl

@juliushaertl
Copy link
Member

I assume we then disable the video if the logo of the instance is changed in the theming app?

@jancborchardt
Copy link
Member

I assume we then disable the video if the logo of the instance is changed in the theming app?

Good point @juliushaertl – yes I’d say if the instance is themed, we can fall back to how the slide previously was.

@rullzer
Copy link
Member Author

rullzer commented Dec 18, 2019

After discussing with @karlitschek lets not care about themed instances for now. We show the vanilla nextcloud screenshots in other places as well.

If people really want to theme it all the way then either disable the firstrunwizard or write your own.

@rullzer
Copy link
Member Author

rullzer commented Dec 18, 2019

@juliushaertl probably easiest to store the video files here somehwere and just have a default get route to fetch them right?

@juliushaertl
Copy link
Member

Ok, yes we can just put them into the firstrunwizard then. We can figure out a way to replace/disable them with theming later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants