V2 - Bugs

[jotoeri]

• The active class on the navigation is cleared when you are in the response view, but should keep having the relevant form highlighted as active. Fix Navigation active on results #379

• Fastly changing forms a few times, somwhen runs into an error, that overwrites one form with another one, and logs TypeError: "this.form.form is undefined" on console Use cancelable request #393

• When deleting a form, the Main-Content (editing Form) is not updated. Fix redirects #377

• When within a result-view and selecting another result-view from sidebar, the Result-Content is not updated. Fix redirects #377

• On mobile, the navigation doesn’t close when you click on a form or create new Close navigation on mobile on new form #380

• The title is just "Forms - Nextcloud" but should be "Form name - Forms - Nextcloud" so you can see the relevant part even when the tab is short. Same for share view Update window title #368

• The actions menu has the form name as a title for every action, leading to it showing when you hover over the action → not necessary and actually confusing, also for accessibility? Only show mouseover-title on text in navigationItem nextcloud-libraries/nextcloud-vue#1098

• When fastly deleting answers by keyboard, a few answers get deleted, then the backspace suddenly applies to the browser, therefore switching pages Fix some small MultipleInput issues #394

• Find a way to merge the two layouts base for both views (they use the same styling for header and form/section) Find a way to merge the two layouts base for both views #400

• When emptying an answer and leaving the edit mode, it remove the empty one (on purpose) but not removed from the database Delete empty options from Db #388

  forms/src/components/Questions/QuestionMultiple.vue

  Line 128 in ee65ef7

  this.$emit('update:options', this.options.filter(answer => !!answer.text))

• Shares are not shown, when opening the edit-mode for the first time

• Add extra padding at the bottom like in creation mode

  forms/src/views/Create.vue

  Line 421 in dd06c46

  margin-bottom: 250px;

• When a form has an expirationDate, this date is not shown when editing the form (in a later session than when it was created, expirationDate not shown/loaded from Db).

• When switching forms, you always get "Formname successfully saved" as notification. This is not really necessary and has to be clicked away always.

• Impossible to close the sidebar at the moment?

• The menu icon overlaps the first line of text

• There is a vertical scrollbar even when there’s almost no content. Seems to be cause there’s some extra whitespace to the top above the content and sidebar

• Form description and questions should be below each other, not side by side

• The content has some different font sizes, especially e.g. for questions. This looks quite off. Instead the questions could be bold to emphasize.

• All the settings in the sidebar are bold, taking away focus and making everything look the same

[jancborchardt]

@skjnldsv @jotoeri I did the ones I could do, none of the remaining items are in my area of expertise anymore. You can take this over, and I’ll move on to the Design review of current state #296 list (where your JS help is also needed ;)

cc @nextcloud/forms if anyone wants to help!

[jancborchardt]

Very nice! Only one missing is

Find a way to merge the two layouts base for both views (they use the same styling for header and form/section)

Is this still relevant, and maybe then we should open a separate issue for that so we can close this collection? And then we can continue on to fixing the rest of Design review of current state #296 :)

[jotoeri]

Is this still relevant, and maybe then we should open a separate issue for that so we can close this collection?

Sounds useful, yes 👍 It's more a code-thing, that imo could also be scheduled for V2.1.

[jancborchardt]

@jotoeri do you want to open a new issue for that, I think you can probably write that down better as I have very little code knowledge. ;)