Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Search is broken #250

Closed
teadur opened this issue Jan 25, 2018 · 25 comments
Closed

Group Search is broken #250

teadur opened this issue Jan 25, 2018 · 25 comments
Labels

Comments

@teadur
Copy link

teadur commented Jan 25, 2018

User creates folder/data, everything is searchable.
Folder is shared to Group.
Group user sees the folder in File view, search gives no results from shared folder.

Group files should yield search results for user, any ideas how to achive it ?

@teadur
Copy link
Author

teadur commented Jan 25, 2018

After further reading, i figured out i need GroupFolders plugin to get the files indexed.

I installed the plugin moved data to there reindexed (all data is indexed for every group member - i think this requires another issue to be fixed because it could be show stopper in env where there is alot of users in group)

But the search is still broken, it seems i'm not the only one #192

While digging deeper it seems that in elasticsearch owner/groups/users fields are empty in files indexed from groupfolders

"_index" : "fulltext_search",
"_type" : "files",
"_id" : "988",
"_score" : 2.971064,
"_source" : {
"owner" : "",
"attachment" : {
"date" : "2017-07-13T08:25:50Z",
"content_type" : "application/pdf",
"language" : "sk",
"content_length" : 7418
},
"groups" : [ ],
"circles" : [ ],
"share_names" : [ ],
"title" : "GroupFolder/xxx/xxx/.pdf",
"users" : [ ],

@magnetic5355
Copy link

+1 group folder files index but do not return results

@ArtificialOwl
Copy link
Member

should be fixed next release

@ArtificialOwl
Copy link
Member

please try 0.6.0 and keep me updated

@ldesgrange
Copy link

ldesgrange commented Feb 15, 2018

I updated to 0.6.0, re-indexed everything, still no result when searching for a file that is stored in a group folder (and as @teadur said, it seems that data are indexed for each user (didn't really checked that but my index is twice the size of the data)).
Is there anything I can do to help you pinpoint what the issue is?

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Feb 15, 2018

could it be that your groups have capitalized character in their name ? If so, this will be fixed with #275

@ldesgrange
Copy link

Yes they all have at least one capitalized character. OK then, I'll wait for #275.

@teadur
Copy link
Author

teadur commented Feb 19, 2018

I dont have capitalized characters in my group names.
Running latest versions of all 3 plugins.

Still no search results for group files.
Can find them correctly from elasticsearch directly:
curl -XGET 'localhost:9200/fulltext_search/_search?q=something&pretty'

"_index" : "fulltext_search",
"_type" : "standard",
"_id" : "files:349",
"_score" : 4.3721504,
"_source" : {
"owner" : "",
"groups" : [ ],
"circles" : [ ],
"title" : "Groupfolder/somefile.pdf",
"users" : [ ],
"content" : "many things"

It seems owner/groups/users fields are still empty.

@ArtificialOwl
Copy link
Member

@teadur : can you do this ?

@JavierNR
Copy link

JavierNR commented Feb 20, 2018

Hello,

I'm experiencing the same behavior under groups folders (can search locally with CURL command)

@daita I've sent you an email with the procedure you indicated.

@teadur
Copy link
Author

teadur commented Feb 22, 2018

@daita

curl -XGET 'localhost:9200/fulltext_search/_search?q=eeldatav&pretty'
{
"took" : 5,
"timed_out" : false,
"_shards" : {
"total" : 5,
"successful" : 5,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : 1,
"max_score" : 6.127439,
"hits" : [
{
"_index" : "fulltext_search",
"_type" : "standard",
"_id" : "files:1344",
"_score" : 6.127439,
"_source" : {
"owner" : "",
"groups" : [ ],
"circles" : [ ],
"title" : "Groupfolder/Avalikud/plaan.pdf",
"users" : [ ],
"content" : "\n\nMingi eeldatav \nmaksumus",
"tags" : [
"local"
],
"attachment" : {
"date" : "2018-02-19T08:09:08Z",
"content_type" : "application/pdf",
"author" : ".",
"language" : "et",
"content_length" : 1621
},
"provider" : "files",
"share_names" : [ ]
}
}
]
}
}

@vschwaberow
Copy link

Same behavior. Any solution to this problem?

@ArtificialOwl
Copy link
Member

working on it, will be fixed in next release of files_fulltextsearch

@fastrandom
Copy link

Hello, do you have a release date?

@ArtificialOwl
Copy link
Member

Please try 0.7

@ArtificialOwl
Copy link
Member

Re-open this ticket if the issue is still here

@tomthecat
Copy link

I wonder why I'm the only one still experiencing problems with group folders. I'm running the latest versions of fulltextsearch in NC 14. Even after reindexing, fulltextsearch finds only filenames but not contents in group folder. Since my first try was a federated share (#400) which was not yet supported, I moved over to group folders. No or only partial luck. Hence I re-open the ticket.

@ArtificialOwl
Copy link
Member

can you describe your way to share your files throw group folders ?

@tomthecat
Copy link

  1. log-in as admin in NC
  2. create group folders in preferences
  3. assign group folder to group "generic", log-out
  4. php occ files:scan --all -v
  5. php occ fulltextsearch:index
  6. log-in as a user (which is a member of the "generic" group): shared folders are accessible
  7. only filesnames could be found by fulltextsearch

@tomthecat
Copy link

Just as an aside: fulltextsearch:index is performed for every user (as mentioned above) which slows down the progress considerably.

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Oct 26, 2018

can you paste the result of ./occ full:check ?

Also, do you have issue with simple text files ?

@tomthecat
Copy link

Full text search 1.0.3
 
- Search Platform:
Elasticsearch 1.0.1
{
    "elastic_host": [
        "http:\/\/localhost:9200"
    ],
    "elastic_index": "nextcloud"
} 
 
- Content Providers:
Files 1.1.0
{
    "files_local": "1",
    "files_external": "0",
    "files_group_folders": "0",
    "files_encrypted": "0",
    "files_federated": "0",
    "files_size": "200",
    "files_pdf": "1",
    "files_office": "1",
    "files_image": "0",
    "files_audio": "0"

Yes, even contents in simple ASCII text were not found.

@ArtificialOwl
Copy link
Member

try enabling the group folders in the settings page :]

@tomthecat
Copy link

Ok, I will try it. But I thought ticking "group folders" in the left panel of the fulltextsearch function in NC (magnifying glass) will do the same...

@tomthecat
Copy link

After re-indexing it is now working. Thanks for pointing out my mistake.

Please close this ticket (again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants