Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Upload via share link from the gallery view #54

Open
2 of 3 tasks
oparoz opened this issue Sep 4, 2016 · 17 comments
Open
2 of 3 tasks

Upload via share link from the gallery view #54

oparoz opened this issue Sep 4, 2016 · 17 comments
Labels
design Related to the design enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@oparoz
Copy link
Member

oparoz commented Sep 4, 2016

From @jancborchardt on July 22, 2015 15:23

Similar to owncloud/gallery#25 (upload straight from the app) but in the share link view.

Use-case: I often share picture folders with friends who also made photos from the same event. Since I want them to add their photos too, I send them the normal share link because there the upload button shows. But it’s the lame list view – I’d much rather have them see the pictures in the nice photo layout, but also be able to add their photos.

@oparoz I assume this is blocked by core just like #25? What is necessary to make it work? Can you maybe even submit a pull request for it?

TODO

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Copied from original issue: owncloud/gallery#225

@oparoz oparoz added design Related to the design enhancement New feature or request junior job labels Sep 4, 2016
@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

The problem is that the upload mechanism is a dated hack, made of strings and which is not in the public space, so using it as-is a recipe for a maintenance nightmare imho. It also violates some oC rules which stipulate we should not create inter-app dependencies.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @jancborchardt on July 22, 2015 16:8

Ok, then we need to reimplement the upload in Gallery to fix this? Or can we safely assume Files is always the base? At least Gallery does not make any sense without Files as base. cc @DeepDiver1975

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

That's what we need:
owncloud/core#17610
but it's in the backlog.

The whole IE compatibility requirement also makes it difficult to introduce new features in official apps via HTML5 classes.

I'd say we should keep this on standby for when Gallery becomes official, because like you said Files is a crucial part of core and it wouldn't be a big deal for an official app to use its scripts if this requirement rises to the top of the queue.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

@karlitschek - Can we make this an HTML5, modern browser only feature? I think it's a nice-to-have feature, not a hard requirement, just like upload works differently in Files, depending on the browser used.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @karlitschek on September 14, 2015 16:4

@MTRichards what do you think?

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @MTRichards on September 14, 2015 18:26

Ok for me if the coolest new stuff only works with a new browser, as long as the IE8 view is not totally mashed, just has to be performed in a different way.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

OK, thanks. It's not for right now anyway, but if I stumble upon a simple way to easily upload a bunch of images to the current folder without loading a large library, it's probably going to be for modern browsers only. I'll know more when I start looking.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @karlitschek on September 14, 2015 20:46

good discussion guys :-)

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @jancborchardt on September 15, 2015 17:45

Yeah – if IE is a blocker for such a major feature, I’d say it’s fine to have it just for the modern browsers. If you only use IE, you will miss nothing.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

@jancborchardt - The first step for this is #25 which will include the necessary libraries and methods to safely upload pictures while avoiding overwriting existing content.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @jancborchardt on December 11, 2015 9:6

Maybe this is something we could advertise via a blog post »Where you can help improve ownCloud« @jospoortvliet? Similar to contributing to the Calendar & Contacts rework?

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

I was also thinking of using something like indiegogo to fund the development of all the features needing a sponsor (like uploading) because I usually have a pretty good idea of how they should be implemented, but that would require some marketing in order to make ownCloud users aware of it.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @jancborchardt on December 11, 2015 13:8

That’s kinda what us being on Bountysource is for. ;) Of course the advertising / marketing to make people aware of that is missing there too.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

The problem is that they've dropped support for campaigns and voluntary donations cover 1 lunch, not a week of development, so yes, letting users know is key.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

This can now be worked on and should be fairly easy to do since uploading is in place.

@unix0r
Copy link

unix0r commented Jul 29, 2019

What is the current status of this issue?
It's still not possible to upload images via a share link, but the mentioned #owncloud/core#23066 is marked as closed.

Also the last update was in 2017.

Running into the same problem now :-)

@jancborchardt jancborchardt added the help wanted Extra attention is needed label Jul 30, 2019
@jancborchardt
Copy link
Member

@unix0r currently no one is working on the issue, so it is up for anyone to pick up. :)

(We do meanwhile have a grid view in the Files app which is nicely polished. If there’s resources free at some point, we also think it’d be nice to refresh the Gallery app. It does however always take time and people. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Related to the design enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Gallery
Backlog
Development

No branches or pull requests

3 participants