Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconfig internal server error #1492

Closed
vondrt4 opened this issue Jan 25, 2019 · 1 comment
Closed

Autoconfig internal server error #1492

vondrt4 opened this issue Jan 25, 2019 · 1 comment

Comments

@vondrt4
Copy link

vondrt4 commented Jan 25, 2019

Expected behavior

A meaningful validation error

Actual behavior

Error while creating the account: Internal Server Error

Mail app

**Mail app version: 0.11

There is a problem with insufficient validation of inputs in the function detectImapAndSmtp. When a new user enters an "e-mail address" that doesn't contain the character '@' in the setup form, this happens:

TypeError: Argument 1 passed to OCA\Mail\Service\AutoConfig\IspDb::query() must be of the type string, null given, called in /usr/share/nextcloud/apps/mail/lib/Service/AutoConfig/IspDbConfigurationDetector.php on line 94

    /usr/share/nextcloud/apps/mail/lib/Service/AutoConfig/IspDbConfigurationDetector.php - line 94:

    OCA\Mail\Service\AutoConfig\IspDb->query(null)

    /usr/share/nextcloud/apps/mail/lib/Service/AutoConfig/AutoConfig.php - line 53:

    OCA\Mail\Service\AutoConfig\IspDbConfigurationDetector->detectImapAndSmtp("a.b.com", "password", "A B")
...

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ChristophWurst ChristophWurst added this to the 0.12.0 milestone Jan 28, 2019
@ChristophWurst ChristophWurst removed this from the 0.12.0 milestone Mar 7, 2019
@ChristophWurst
Copy link
Member

This was reworked in #2259. Please test with a recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants