Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show Important and favorites if there are no messages #3402

Open
marcoambrosini opened this issue Jul 26, 2020 · 5 comments
Open

Do not show Important and favorites if there are no messages #3402

marcoambrosini opened this issue Jul 26, 2020 · 5 comments

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Jul 26, 2020

I think that:

  • If there are no "favorites" nor "important" mails => the three captions should disappear and the priority inbox should look just like "All inboxes"
  • If there are "favorite" messages but not important => only the favorite captions should show and vice versa

In other words I think there's no gain in showing captions with empty content when there are no messages and offset the message list by ~300px

Screenshot from 2020-07-26 19-10-19

@GretaD
Copy link
Contributor

GretaD commented Jul 28, 2020

Yes but that might cause confusion and thus people not using Priority Inbox. If we remove the important when there's no messages then people will not know how we actually show the important ones and might never mark one as such. The space is relatively small so no matter how small your screens are, the other will be always visible.

I think it doesnt bring any good to have 2 All Inboxes that looks the same, and also by keeping it this way people get a better idea how Priority Inbox looks like.

@GretaD GretaD added enhancement and removed bug labels Jul 28, 2020
@marcoambrosini
Copy link
Member Author

Let's discuss this in the app review cal when it's mail's turn @GretaD :)

@ghost
Copy link

ghost commented Dec 3, 2020

@Greta @ma12-co
This was discussed during last contributor week in Mail design review.

Not only "No messages" should be shown but e.g. "Messages marked as important will show up here" with the icon-important, and "Favorite messages will show up here" with the icon-favorite.
Favorites will be invisible or may be moved out of PI completely to Navigation Bar.

@GretaD
Copy link
Contributor

GretaD commented Dec 3, 2020

@Greta @ma12-co
This was discussed during last contributor week in Mail design review.

Not only "No messages" should be shown but e.g. "Messages marked as important will show up here" with the icon-important, and "Favorite messages will show up here" with the icon-favorite.

Yep, so im improving this for now.

Favorites will be invisible or may be moved out of PI completely to Navigation Bar.

No final decision was taken for this one so lets improve this when Jan is back.

@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants