Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show each thread once per message list #3652

Closed
ChristophWurst opened this issue Sep 24, 2020 · 10 comments · Fixed by #5106
Closed

Only show each thread once per message list #3652

ChristophWurst opened this issue Sep 24, 2020 · 10 comments · Fixed by #5106

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 24, 2020

Right now we still show the actual mailbox' contents and list messages. Threads are only shown when you open an individual message.

We should change the list to show threads in a sense that messages of the same thread are only shown once and at the position of the latest message.

@ChristophWurst ChristophWurst created this issue from a note in Threading (To do) Sep 24, 2020
@ChristophWurst ChristophWurst changed the title Only show each thread once per message list. Only show each thread once per message list Sep 24, 2020
@StCyr
Copy link
Collaborator

StCyr commented Sep 27, 2020

Also, you are right that the logic that applies to messages/envelopes is not the same at the one applying to threads. For example: Specific logic must happen when clicking on the "Delete" action of a thread

@StCyr
Copy link
Collaborator

StCyr commented Sep 27, 2020

Do you think we can say that only thread root messages have a non-null inReplyTo field once the message/envelope list has been cleaned from all threads' children (that's: the message/envelope list only contains messages that are not in a thread or are the root message of a thread).

Stated otherwise: Do you think that using the inReplyTo field is a proper way to discriminate thread root messages from non-threaded messages?

@ChristophWurst
Copy link
Member Author

Stated otherwise: Do you think that using the inReplyTo field is a proper way to discriminate thread root messages from non-threaded messages?

Maybe we can use this as discriminator if we combine with References. Like if both headers are empty, this message has no ancestors. So it is a root (but possibly a root of an otherwise empty thread).

@alexanderdd
Copy link

Please keep in mind that in order to start a new thread, people often reply to some previous message and just change the subject. Hope this does not mess up your implementation idea.

@ChristophWurst
Copy link
Member Author

Don't worry. The subject has little weight in this algorithm. You can check the implementation and the algorithms we based it on at #3355

@alexanderdd
Copy link

The subject has little weight in this algorithm.

Thats not good. So if someone takes an old mail, changes the subject and sends it, it will be grouped with the other, old mail? Because that is not the intention of the user, who deliberately changed the subject.

@StCyr
Copy link
Collaborator

StCyr commented Oct 7, 2020

The subject has little weight in this algorithm.

Thats not good. So if someone takes an old mail, changes the subject and sends it, it will be grouped with the other, old mail? Because that is not the intention of the user, who deliberately changed the subject.

Well, it’s 2020, users should know that the subject doesn’t govern threading algorithmes, but rather messageId, references, InReplyTo,... headers

I know it’s technical but users should be used to that kind of behaviour I believe

@ChristophWurst
Copy link
Member Author

@alexanderdd we simply follow https://tools.ietf.org/html/rfc5256. No need to downvote explanations of how things are supposed to work. Please read that RFC and https://www.jwz.org/doc/threading.html. Things should be more clear afterwards.

@alexanderdd
Copy link

Ok then. I just wanted to point out that this will lead to a bad user experience, because users follow intution, not RFC. (That is why I downvoted StCyr's comment -- expecting the user to "know that subject doesn’t govern threading algorithmes, but rather messageId" is bad UX design - ask any UX expert).

Maybe it is possible for the mail app to assign a new messageId if the user changes the subject by hand -- should I open a separate issue for that?

@ChristophWurst
Copy link
Member Author

We can talk about a feature request like allow users to branch off a thread into a new one or similar but the default should be to stay in the thread.

💌 📅 👥 Groupware team automation moved this from In progress to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4 participants