Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to deduplicate same address for a contact #1013

Closed
vincowl opened this issue Mar 22, 2023 · 5 comments
Closed

Add an option to deduplicate same address for a contact #1013

vincowl opened this issue Mar 22, 2023 · 5 comments

Comments

@vincowl
Copy link
Contributor

vincowl commented Mar 22, 2023

I have some contacts who have the same professional address as their personal one. It would be great to add an option to deduplicate these adresses, thus it would display only one marker instead of multiple ones for a same contact. If it sounds interesting I can try to submit a PR

@tacruc
Copy link
Collaborator

tacruc commented Mar 22, 2023

This sounds cool.
A PR would be highly appreciate.

@tacruc
Copy link
Collaborator

tacruc commented Mar 22, 2023

If you need help or have questions, feel free to ask.

@tacruc
Copy link
Collaborator

tacruc commented Mar 24, 2023

Actually I would not make it an option. I would just deduplicate them always.

@vincowl
Copy link
Contributor Author

vincowl commented Mar 26, 2023

Fine ! I'll donthat and submit a PR as soon as I'll have Time for this. I'll juste deduplicate if addresses are exactly the same string.

@tacruc
Copy link
Collaborator

tacruc commented Jul 1, 2023

Fix thanks to @vincowl

@tacruc tacruc closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants