fix: Make sure dependencies are external

Rollup does check strings for full match, so transforming our dependencies list to RegExp will work even with imports like `import 'core-js/foo/bar`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nextcloud-libraries · Jun 21, 2023 · 1d78f88 · 1d78f88
1 parent ca51f67
commit 1d78f88
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/babel.config.js b/babel.config.js
@@ -5,7 +5,7 @@ export default {
             "@babel/env",
             {
                 useBuiltIns: "usage",
-                corejs: "3.0.0",
+                corejs: "3",
             },
         ],
     ],

diff --git a/rollup.config.js b/rollup.config.js
@@ -23,7 +23,10 @@ const packageJson = JSON.parse(
 	)
 )
 
-const externals = [...Object.keys(packageJson?.dependencies || {}), ...Object.keys(packageJson?.peerDependencies || {})]
+const externals = [
+	...Object.keys(packageJson?.dependencies || {}),
+	...Object.keys(packageJson?.peerDependencies || {})
+].map(packageName => new RegExp(`^${packageName}`))
 
 const translations = fs
 	.readdirSync('./l10n')