Improve testability + small code changes of AppSideBarTabs #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiquidITGuy
force-pushed
the
improve-testability
branch
4 times, most recently
from
e6b539d
to
f8976f7
Compare
This comment has been minimized.
This comment has been minimized.
violoncelloCH
added
3. to review
|
May I ask for some feedback ? |
|
Hey!! |
|
Could you rebase to master? |
Sure I will do it tomorrow :) |
Changed way to stub console in test Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Remove the duplicate stub make the test more resilient Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
Signed-off-by: Simon Belbeoch <sbelbeoch@octo.com> Signed-off-by: Simon Belbeoch <simon.belbeoch@octo.com>
LiquidITGuy
force-pushed
the
improve-testability
branch
from
f8976f7
to
d816967
Compare
|
@skjnldsv done :) |
skjnldsv
approved these changes
Nov 19, 2020
|
Very nice!! |
skjnldsv
requested review from
raimund-schluessler,
juliushaertl,
PVince81 and
ChristophWurst
|
🎉 🎉 🎉 🎉 |
|
Thank you so much @LiquidITGuy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added unit tests on already tested component to familiarize myself with the code.
I also fix some warning on the passing tests of the current code (stub of console does not work as expected)
During this phase I found a bug with the key listener.
According to the documentation, we can use the kebab-case standard even if it’s not a defined shortcut.
https://vuejs.org/v2/guide/events.html#Key-Modifiers
But it doesn’t seem to work on every system.
Other events seems to trigger the listeners ‘keydown.page-up’ and ‘page down’.
You can try it with the written tests.
According to Vue-test-utils the key to trigger it in tests are ‘pageup’ and ‘pagedown’.
https://vue-test-utils.vuejs.org/guides/dom-events.html
May it be an issue in Vuejs listener process on some engines?
For now I fixed it with the keyboard code.
After writing those tests, I make some minor change into the code to make it easier to reuse.
I would be happy to have feedback to know if pull requests like this one can be helpful or not or to view it merged :).
