Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action button text for long translations #1576

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Fix action button text for long translations #1576

merged 1 commit into from
Nov 23, 2020

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 17, 2020 •
edited

the problem
before_longtezt

@GretaD GretaD changed the title Fix long text for action button Fix long text for action button in different languages Nov 17, 2020
@GretaD

This comment has been minimized.

Sign in to view
@GretaD GretaD mentioned this pull request Nov 17, 2020
Closed
@GretaD GretaD changed the title Fix long text for action button in different languages Fix action button text for long translations Nov 17, 2020
@GretaD GretaD added 2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design labels Nov 17, 2020
@skjnldsv

This comment has been minimized.

Sign in to view
@GretaD

This comment has been minimized.

Sign in to view
@skjnldsv
Copy link
Contributor

I tried adding width: 100% that also needs a display: block on __title. But still doesnt work.

You need a bit more :)

	text-overflow: ellipsis;
	overflow: hidden;
	white-space: nowrap;
	max-width: 100%;
	display: inline-block;

@skjnldsv
Copy link
Contributor

Capture d’écran_2020-11-17_19-36-36

@GretaD
Fix long text for action button
0c80ecf 
Signed-off-by: GretaD <gretadoci@gmail.com>
skjnldsv
skjnldsv reviewed Nov 18, 2020
View reviewed changes
src/assets/action.scss
@@ -90,7 +90,7 @@

// long text area
p {
width: 150px;
width: 185px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure @jancborchardt is ok with this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @jancborchardt

@GretaD
Copy link
Contributor Author

GretaD commented Nov 18, 2020

I also increased a bit the p width, to make sure to ellips only very long translations and not everything that is a bit longer than english

@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 18, 2020
@GretaD GretaD marked this pull request as ready for review November 18, 2020 14:32
@skjnldsv skjnldsv merged commit ad8dd3a into master Nov 23, 2020
@skjnldsv skjnldsv deleted the fix/longtext_actionbutton branch November 23, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GretaD @skjnldsv @juliushaertl