Allow disabling the avatar menu #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also hide clickability from screen reader by not registering the click event when not clickable. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
enhancement
PVince81
requested review from
ChristophWurst,
juliushaertl and
marcoambrosini
skjnldsv
reviewed
Nov 23, 2020
| @@ -44,7 +44,7 @@ | |||
| }" | |||
| :style="avatarStyle" | |||
| class="avatardiv popovermenu-wrapper" | |||
| @click="toggleMenu"> | |||
| v-on="disableMenu ? { click: toggleMenu } : {}"> | |||
There was a problem hiding this comment.
There is also this syntax since 2.6 <div @[event]="handler" /> if you prefer
skjnldsv
approved these changes
Nov 23, 2020
marcoambrosini
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide clickability from screen reader by not registering the click event when not clickable.