Richcontenteditable: bind event listeners #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
added
3. to review
skjnldsv
reviewed
Nov 20, 2020
Tried that first, didn't work for me |
|
If so then let's forward all listeners |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
reviewed
Nov 23, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
richcontenteditable-forward-esc-keypress
branch
from
0f081a0
to
a7e7ed8
Compare
marcoambrosini
changed the title
skjnldsv
approved these changes
Nov 23, 2020
|
You were right @skjnldsv, shame on me! |
ChristophWurst
approved these changes
Nov 24, 2020
|
Unrelated error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to dismiss an edit from the parent.
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me