Aria-expanded must be a false string, not absent #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting the boolean to false, the DOM attribute "aria-expanded" disappears. For screen readers to be able to say "Actions push button collapsed" the attribute must be present and set to the string "false" instad of absent. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
bug
PVince81
requested review from
ChristophWurst,
juliushaertl and
marcoambrosini
marcoambrosini
approved these changes
Nov 24, 2020
ChristophWurst
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the boolean to false, the DOM attribute "aria-expanded"
disappears.
For screen readers to be able to say "Actions push button collapsed" instead of just "Actions push button" the
attribute must be present and set to the string "false" instead of
absent.
Discovered this by comparing screen reader behavior with the example from https://www.w3.org/TR/2016/WD-wai-aria-practices-1.1-20161214/examples/menu-button/menu-button-1/menu-button-1.html