Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link support to richcontenteditor and fix various issues #1669

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Add link support to richcontenteditor and fix various issues #1669

merged 1 commit into from
Jan 18, 2021

Conversation

skjnldsv
Copy link
Contributor

  • Add link support on rendering
  • Make sure we also decode &
  • Replaced badly used value variable
  • Make sure regex are multilines and insensitive

@skjnldsv
Add link support to richcontenteditor and fix various issues
f4c33ed 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Jan 15, 2021
@skjnldsv skjnldsv self-assigned this Jan 15, 2021
nickvergessen
nickvergessen approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and does the trick for nextcloud/spreed#4950

@nickvergessen nickvergessen mentioned this pull request Jan 15, 2021
Merged
3 tasks
PVince81
PVince81 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 2776652 into master Jan 18, 2021
@PVince81 PVince81 deleted the fix/rich-content-links-and-various branch January 18, 2021 08:16
@PVince81
Copy link
Contributor

regression in Safari: nextcloud/spreed#4995

seems this new linkify-url lib doesn't work with Safari
and now wondering why we didn't use linkifyjs instead

@PVince81
Copy link
Contributor

fix for the regression, make it use linkifyjs instead: #1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@julien-nc julien-nc Awaiting requested review from julien-nc

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @PVince81 @nickvergessen