Fix longtext appearance for avatar popover menu #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use longtext with the avatar menu as it will mostly contain user names and email addresses which can become long. The longtext mode automatically triggers wrapping by default. However, in the case of long email addresses we can't wrap on spaces, so an ellipsis has been added as well. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
nickvergessen
approved these changes
Jan 20, 2021
maybe |
while it works for the email address, it breaks the other items in an unwanted way: and at this level of the code we can't know what the contents of the menu items is about as it's returned by the server in a generic manner |
PVince81
requested review from
ChristophWurst,
violoncelloCH and
juliushaertl
marcoambrosini
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use longtext with the avatar menu as it will mostly contain user names
and email addresses which can become long.
The longtext mode automatically triggers wrapping by default.
However, in the case of long email addresses we can't wrap on spaces, so
an ellipsis has been added as well.
(note, there is no white-space mode that can break in the middle of a string, so this is the best we got)
For nextcloud/spreed#4976 (comment)