Revert workaround for popper glitch, fix regression #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the workaround that existed to dodge popper.js glitch where the popover appeared in the wrong position first and a few milliseconds later in the right place. This fixes a regression where the regular Popover wasn't working any more. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
bug
PVince81
requested review from
ChristophWurst,
marcoambrosini,
juliushaertl,
dartcafe and
nickvergessen
|
Original code was introduced in #831 where the Avatar got switched to use the Popover component |
marcoambrosini
approved these changes
Jan 26, 2021
dartcafe
approved these changes
Jan 27, 2021
PVince81
deleted the
bugfix/1681/revert-tooltip-hack-fix-popover-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the workaround that existed to dodge popper.js glitch where the
popover appeared in the wrong position first and a few milliseconds
later in the right place.
This fixes a regression where the regular Popover wasn't working any
more.
Fixes #1681
The glitch will be addressed in #1683