Allow to toggle editable title by click #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
2 times, most recently
from
0c6c5b6
to
2e07637
Compare
raimund-schluessler
requested review from
skjnldsv,
jancborchardt and
georgehrke
4 tasks
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
from
0221864
to
1155a8b
Compare
raimund-schluessler
added
enhancement
skjnldsv
requested changes
Aug 17, 2020
Merged
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
2 times, most recently
from
b86ec97
to
07b7721
Compare
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
2 times, most recently
from
d41290e
to
2a1aa31
Compare
skjnldsv
reviewed
Aug 17, 2020
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
3 times, most recently
from
aa8d0e7
to
5558c61
Compare
|
Shall we also edit the editable title example to use |
yes so we can have both please :) |
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
from
5558c61
to
871d64a
Compare
|
I added an editable title after click example. |
skjnldsv
reviewed
Aug 19, 2020
|
I'm an idiiot, I thought this pr was already in, so this is why I edited my other pr #1303 ... 🙈 |
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
2 times, most recently
from
188da04
to
4124540
Compare
skjnldsv
reviewed
Aug 19, 2020
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/1090/editable-title
branch
from
4124540
to
6990476
Compare
skjnldsv
reviewed
May 3, 2021
| @click.self="editTitle($event)" /> | ||
| <template v-if="titleEditable"> | ||
| <form | ||
| v-click-outside="() => onSubmitTitle()" |
There was a problem hiding this comment.
@raimund-schluessler I just noticed this, we do not forward any event here. 🙈
Any reason you did not just do that?
Suggested change
| v-click-outside="() => onSubmitTitle()" | |
| v-click-outside="onSubmitTitle" |
There was a problem hiding this comment.
No, I probably just overlooked it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to show the title input field by clicking on the title. Also it makes sure that the title input is rendered in the same style as the title itself:
Partially implements #1090.