Snapshot test for usernameToColor function #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
commented
Aug 25, 2020
| const snapshot = require('./../src/functions/usernameToColor/__snapshots__/usernameToColor.spec.js.snap') | ||
| const result = {} | ||
| Object.keys(snapshot).map((key) => { | ||
| const uid = key.replace('usernameToColor ', '').replace(' has the proper color 1', '') |
There was a problem hiding this comment.
There might be a more sane way to properly deserialize the jest snapshot but for now this does the trick
|
Can we also have a tests for
|
src/functions/usernameToColor/__snapshots__/usernameToColor.spec.js.snap
Outdated
Show resolved
Hide resolved
skjnldsv
added
2. developing
juliushaertl
added
3. to review
juliushaertl
force-pushed
the
tests/noid/color-snapshot
branch
from
25bd5a2
to
3aeccc4
Compare
|
Ping? :D |
|
Pong .... Waiting for reviews 😁 |
skjnldsv
reviewed
Oct 14, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
tests/noid/color-snapshot
branch
from
3aeccc4
to
cb71924
Compare
marcoambrosini
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic snapshot testing for the usernameToColor functionality, which mainly aims to get a testset that we can use to test different implementations of the same algorithm against, e.g. in the android app.
A JSON export can be generated with
node ./build/usernameToColor-export.jsJSON output for the current snapshot
{"":"#0082c9",",":"#1e78c1",".":"#c98879","123e4567-e89b-12d3-a456-426614174000":"#bc5c91","Akeel Robertson":"#9750a4","Alishia Ann Lowry":"#d09e6d","Arham Johnson":"#0082c9","Brayden Truong":"#d09e6d","Daphne Roy":"#9750a4","Ellena Wright Frederic Conway":"#c37285","Gianluca Hills":"#d6b461","Haseeb Stephens":"#d6b461","Idris Mac":"#9750a4","Kristi Fisher":"#0082c9","Lillian Wall":"#bc5c91","Lorelai Taylor":"#ddcb55","Madina Knight":"#9750a4","Meeting":"#c98879","Private Circle":"#c37285","Rae Hope":"#795aab","Santiago Singleton":"#bc5c91","Sid Combs":"#d09e6d","TestCircle":"#499aa2","Tom Mörtel":"#248eb5","Vivienne Jacobs":"#1e78c1","Zaki Cortes":"#6ea68f","a user":"#5b64b3","admin":"#d09e6d","admin@cloud.example.com":"#9750a4","another user":"#ddcb55","asd":"#248eb5","bar":"#0082c9","foo":"#d09e6d","wasd":"#b6469d","مرحبا بالعالم":"#c98879","🙈":"#b6469d"}cc @tobiasKaminsky