Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to choose boundariesElement for actions' popover #1351

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

marcoambrosini
Copy link
Contributor

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/noid/boundaries-element-for-actions branch from 37cb6e0 to 1f61494 Compare August 26, 2020 07:51
@marcoambrosini marcoambrosini changed the title Allow to choose boundariesElement for actions Allow to choose boundariesElement for actions' popover Aug 26, 2020
@nickvergessen nickvergessen added bug Something isn't working feature: actions Related to the actions components labels Aug 26, 2020
@georgehrke
Copy link
Contributor

@ma12-co Does this fix #1345 ? :)

@ChristophWurst ChristophWurst merged commit eec177b into master Aug 26, 2020
@ChristophWurst ChristophWurst deleted the feature/noid/boundaries-element-for-actions branch August 26, 2020 08:37
@nickvergessen
Copy link
Contributor

Does this fix #1345 ? :)

It allows you do fix it yeah, by specifying the element yourself.

@georgehrke
Copy link
Contributor

Well, not really, since you can't set custom props for the actions component for secondary actions:
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/AppSidebar/AppSidebar.vue#L211

Let me see if adding .app-sidebar as a boundary works there.

@marcoambrosini
Copy link
Contributor Author

Let me see if adding .app-sidebar as a boundary works there.

It does :)

@marcoambrosini
Copy link
Contributor Author

But it actually should be an object, not a string :/

@marcoambrosini
Copy link
Contributor Author

I'm testing now with the dom element body and it seems to work. Seems to be that we were passing in the string "body"

@marcoambrosini
Copy link
Contributor Author

marcoambrosini commented Aug 26, 2020

Can confirm: It works by passing the html body element, without the need of specifying a boundarieselement. I have a problem with the prop type check though. Should I just remove it?

Screenshot from 2020-08-26 11-03-00

Screenshot from 2020-08-26 11-04-07

EDIT: if I remove the prop type eslint will fail

@georgehrke
Copy link
Contributor

@ma12-co See https://github.com/Akryum/v-tooltip/blob/fa672f6d6d2004d9cb285ce4551f12c9ca1f6540/src/components/Popover.vue#L114L117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants