Cover more cases in AppSidebare visual test #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
raimund-schluessler
requested review from
georgehrke,
skjnldsv and
juliushaertl
raimund-schluessler
force-pushed
the
feature/noid/AppSidebarTest
branch
from
c4ccd75
to
11146c8
Compare
skjnldsv
approved these changes
Aug 27, 2020
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
feature/noid/AppSidebarTest
branch
from
11146c8
to
1b7957b
Compare
raimund-schluessler
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more test cases for the visual regression test of AppSidebar. I added
In principle nothing dramatic showed up, but there are two issues.
The padding might not be ideal when editing the title, see [2.6] Spacing issue for title input #1347:
and in case no primary action is present (compact mode or no figure), there is to much padding on the right of the title:
To keep things clear, I only changed the test here. So it should be easy to review and merge. Since the test names changed, I uploaded new images for every test.
Actually adjusting the CSS will be done in a follow-up PR.