Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix active tab prop #1368

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Fix active tab prop #1368

merged 1 commit into from
Sep 1, 2020

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 1, 2020

Breaks server

@skjnldsv
Fix active tab prop
825fade 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority regression Regression of a previous working feature labels Sep 1, 2020
@skjnldsv skjnldsv self-assigned this Sep 1, 2020
@skjnldsv skjnldsv mentioned this pull request Sep 1, 2020
Merged
@raimund-schluessler
Copy link
Contributor

Indeed, another regression by #1281 🙈

@julien-nc julien-nc self-requested a review September 1, 2020 12:19
julien-nc
julien-nc approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now. Tested in Cospend.

@skjnldsv skjnldsv merged commit 650f980 into master Sep 1, 2020
@skjnldsv skjnldsv deleted the fix/active-tab branch September 1, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@julien-nc julien-nc julien-nc approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @raimund-schluessler @julien-nc