Fetch user status in avatar only if it is going to be shown #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
bug
danxuliu
requested review from
nickvergessen,
georgehrke,
skjnldsv and
marcoambrosini
Before the user status was always fetched when the component was mounted, even if "showUserStatus" was false. If the avatar was never meant to show the user status that caused unneeded requests (for example, in the chat view of Talk). Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
fetch-user-status-in-avatar-only-if-it-is-going-to-be-shown
branch
from
0aa5292
to
a859db7
Compare
skjnldsv
approved these changes
Sep 3, 2020
juliushaertl
approved these changes
Sep 3, 2020
juliushaertl
deleted the
fetch-user-status-in-avatar-only-if-it-is-going-to-be-shown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the user status was always fetched when the component was mounted,
even if "showUserStatus" was false. If the avatar was never meant to
show the user status that caused unneeded requests (for example, in the
chat view of Talk).