Add loading state on AppSidebar and remove unwanted slot bind #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skjnldsv
commented
Oct 4, 2020
•
skjnldsv
commented
- Added loading prop to AppSidebar
- Removed non-working slot v-bind
- Moved active show/hide to the css instead of relying on v-show to avoid conflicts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
ChristophWurst,
raimund-schluessler,
juliushaertl and
julien-nc
skjnldsv
added
3. to review
skjnldsv
commented
Oct 4, 2020
| @@ -67,7 +69,8 @@ export default { | |||
| </script> | |||
|
|
|||
| <style lang="scss" scoped> | |||
| section { | |||
| .app-sidebar__tab { | |||
| display: none; | |||
There was a problem hiding this comment.
By moving this to the css, we allow to use v-show on the AppSidebarTab as well, otherwise it was conflicting as we'd have two handlers, from the inside and from the outside.
ChristophWurst
approved these changes
Oct 5, 2020
juliushaertl
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.