Fix modal freeze #1432
Merged
Fix modal freeze #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
juliushaertl
requested review from
skjnldsv,
marcoambrosini and
ChristophWurst
juliushaertl
added
3. to review
skjnldsv
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Modal component might freeze completely if it gets destroyed when its parent is destroyed. This is caused by the forced mount to body. To fix this I added a lifecycle hook that cleans up the injected html element after the component has been destroyed.
Additionally, I noticed that the modal code uses the lifecylce hook
unmountedwhich is not existing in vue v2 (see the documentation). The dead code was moved to the corresponding hookbeforeDestroy.Found the bug while developing nextcloud/mail #3591.