Adds information to README.md file how to use vue-devtools #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
reviewed
Oct 9, 2020
skjnldsv
added
3. to review
StCyr
force-pushed
the
fix/update-readme-for-devtools
branch
from
59fd444
to
3b03c17
Compare
skjnldsv
reviewed
Oct 9, 2020
README.md
Outdated
Comment on lines
58
to
73
| diff --git a/lib/public/AppFramework/Http/ContentSecurityPolicy.php b/lib/public/AppFramework/Http/ContentSecurityPolicy.php | ||
| index 3a9ab8f8c1..4bc2b4a4d0 100644 | ||
| --- a/lib/public/AppFramework/Http/ContentSecurityPolicy.php | ||
| +++ b/lib/public/AppFramework/Http/ContentSecurityPolicy.php | ||
| @@ -42,9 +42,9 @@ namespace OCP\AppFramework\Http; | ||
| */ | ||
| class ContentSecurityPolicy extends EmptyContentSecurityPolicy { | ||
| /** @var bool Whether inline JS snippets are allowed */ | ||
| - protected $inlineScriptAllowed = false; | ||
| + protected $inlineScriptAllowed = true; | ||
| /** @var bool Whether eval in JS scripts is allowed */ | ||
| - protected $evalScriptAllowed = false; | ||
| + protected $evalScriptAllowed = true; | ||
| /** @var array Domains from which scripts can get loaded */ | ||
| protected $allowedScriptDomains = [ | ||
| '\'self\'', |
There was a problem hiding this comment.
Maybe add some code block with diff linting? Dunno if github supports it right away 🤔
There was a problem hiding this comment.
I don't understand sorry :(
There was a problem hiding this comment.
a block quote https://stackoverflow.com/a/40883538/3885878
There was a problem hiding this comment.
yes it works!
I've updated my PR
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
StCyr
force-pushed
the
fix/update-readme-for-devtools
branch
from
3b03c17
to
48f2fb5
Compare
skjnldsv
approved these changes
Oct 12, 2020
GretaD
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyrille Bollu cyrpub@bollu.be