Allow an "extra" slot for the AppNavigationItem #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to mount a Modal for an item in the navigation it becomes tricky to mount the (virtual or not in-place) modal component from the navigation. To avoid more complexity itwold be convenient to just mount the component inside the navigation with the intention that it shouldn't really render anything in-place. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsv
added
3. to review
skjnldsv
approved these changes
Oct 20, 2020
4 tasks
GretaD
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to mount a Modal for an item in the navigation it becomes
tricky to mount the (virtual or not in-place) modal component from the
navigation. To avoid more complexity itwold be convenient to just mount
the component inside the navigation with the intention that it shouldn't
really render anything in-place.
For nextcloud/mail#3569