Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve settings dialog layout #1708

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Improve settings dialog layout #1708

merged 1 commit into from
Feb 15, 2021

Conversation

marcoambrosini
Copy link
Contributor

fix #1629

Peek.2021-02-12.09-43.mp4

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@marcoambrosini
Improve settings dialog layout
2d55cc6 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Feb 12, 2021
@marcoambrosini marcoambrosini self-assigned this Feb 12, 2021
GretaD
GretaD approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with mail app and works good

jancborchardt
jancborchardt approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! :)

@ma12-co for Talk specifically I’d say it would look even nicer if audio and video settings would be left and right of each other (on wider views). Then the dropdowns are not so super wide, and you see more other settings too.

@marcoambrosini marcoambrosini merged commit 37c1c00 into master Feb 15, 2021
@marcoambrosini marcoambrosini deleted the improve-settings-dialog branch February 15, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@GretaD GretaD GretaD approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings modal padding and sizing
3 participants
@marcoambrosini @jancborchardt @GretaD