Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we can check the classList on the node #1723

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Make sure we can check the classList on the node #1723

merged 1 commit into from
Feb 24, 2021

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Feb 24, 2021 •
edited
Loading

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority labels Feb 24, 2021
@skjnldsv skjnldsv self-assigned this Feb 24, 2021
julien-nc
julien-nc approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also affects the whiteboard integration app. I didn't try it but it seems good.

@skjnldsv skjnldsv merged commit 6e4db7f into master Feb 24, 2021
@skjnldsv skjnldsv deleted the fix/iframe-excludeClickOutsideClasses-middleware branch February 24, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@sam-19 sam-19 Awaiting requested review from sam-19

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on an IFrame causes error in v-click-outside middleware
3 participants
@skjnldsv @julien-nc @marcoambrosini