Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Settings css #1770

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix Settings css #1770

merged 1 commit into from
Mar 25, 2021

Conversation

jotoeri
Copy link
Contributor

@jotoeri jotoeri commented Mar 19, 2021

Under the assumption it is a bug and not a new design feature, this fixes:

  • SettingsSection was missing the separating border at the bottom
  • Distance of Header and desciption adapted:

Settings before Vue:
policy_setting_old

Settings currently on Vue-Components:
policy_setting_vue_wrong

Settings after this PR is merged:
policy_setting_vue_new

@jotoeri jotoeri added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. design Design, UX, interface and interaction design labels Mar 19, 2021
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@raimund-schluessler raimund-schluessler merged commit 71fae44 into master Mar 25, 2021
@raimund-schluessler raimund-schluessler deleted the fix/settings_design branch March 25, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants