Use ActionButton for AppNavigationToggle

[raimund-schluessler]

This is another approach to #1843. We simply use ActionButton for the AppNavigationToggle now and let it do the heavy lifting.

hover/focus feedback after:

[jancborchardt]

When testing with a screenreader, the aria label seems to be duplicated, it reads:

navigation, open navigation collapsed pushbutton, open navigation

And when the navigation is open:

navigation, close navigation expanded pushbutton, close navigation

So it seems we should actually not have the aria-label because the "navigation" already comes from the role="navigation" on the parent. Then it would just be "navigation, expanded pushbutton".

[raimund-schluessler]

When testing with a screenreader, the aria label seems to be duplicated, it reads:

navigation, open navigation collapsed pushbutton, open navigation

And when the navigation is open:

navigation, close navigation expanded pushbutton, close navigation

So it seems we should actually not have the aria-label because the "navigation" already comes from the role="navigation" on the parent. Then it would just be "navigation, expanded pushbutton".

@jancborchardt Would it be possible that you adjust that? I don't have a screenreader at hand.

[jancborchardt]

@jancborchardt Would it be possible that you adjust that? I don't have a screenreader at hand.

I could try – but which system are you on? If you use GNOME, you can simply go to "Universal Access" and activate the screenreader from there. :)

[jancborchardt]

Fixed it :) @raimund-schluessler the issue was simply that the aria-label was duplicating the text which was already in the ActionButton, so removing the aria-label fixed it.

[jancborchardt]

Works great now! :)

[jancborchardt]

@skjnldsv could you check and approve if your change request is addressed? :)

[jotoeri]

How about a backport here? 😉