Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListItemIcon listeners #1870

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 21, 2021

Needed to make sure the events listeners we apply to the parent are forwarded

You can test on the docs, on master, adding a @click= does not work.
Here, it does :)

<template>
	<ListItemIcon title="User 1" @click="alert" />
</template>

<script>
export default {
	methods: {
		alert() {
			alert(...arguments)
		}
	}
}
</script>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Apr 21, 2021
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working feature: list-item-icon Related to the list-item-icon component labels Apr 21, 2021
@skjnldsv
Copy link
Contributor Author

/backport to stable3

@ChristophWurst ChristophWurst merged commit 1194bd8 into master Apr 21, 2021
@ChristophWurst ChristophWurst deleted the fix/ListItemIcon-listeners branch April 21, 2021 07:07
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item-icon Related to the list-item-icon component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants